Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5631/3/fe/src/main/java/org/apache/impala/analysis/CaseExpr.java File fe/src/main/java/org/apache/impala/analysis/CaseExpr.java: Line 133: BinaryPredicate.Operator.EQ, encoded.clone(), candidate)); explain somewhere why this is needed http://gerrit.cloudera.org:8080/#/c/5631/3/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java: Line 234: // correctly when FoldConstantRule is used. this needs to be a test case in exprs.test (ie, a functional test), you don't want to test just for a specific rule. (what if some other rule gets added later that reintroduces the bug?) -- To view, visit http://gerrit.cloudera.org:8080/5631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4de9ed7118c8d18ec3f02ff74c9cca211c716e51 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
