Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5631/4/fe/src/main/java/org/apache/impala/analysis/CaseExpr.java File fe/src/main/java/org/apache/impala/analysis/CaseExpr.java: Line 133: children_.add(encodedIsNull.clone()); another one that was missed. it looks like this is easy to break (in the future). please add a verification step at the end of this c'tor that checks that the expr tree rooted at 'this' doesn't contain encoded or encodedIsNull. extend TreeNode if you don't find a good functional match. -- To view, visit http://gerrit.cloudera.org:8080/5631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4de9ed7118c8d18ec3f02ff74c9cca211c716e51 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
