Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4678: move query MemTracker into QueryState ......................................................................
IMPALA-4678: move query MemTracker into QueryState The query MemTracker for query execution is now owned directly by QueryState, which greatly simplifies the lifecycle of the MemTracker. This required various other changes and enabled some simplifications. * The coordinator's QueryState is constructed earlier before fragments are sent out, since we need a MemTracker at that point. * The global query MemTracker map can be removed. * The static request pool mem tracker is moved into into ExecEnv. * Temporary query MemTrackers used to evaluate expressions during planning do not need to be registered globally and are owned directly by the RuntimeState. * Various cleanup logic is moved around to reflect the other changes. Change-Id: Id6b46652932b5638993623e98d1f0d60d8380ba0 Reviewed-on: http://gerrit.cloudera.org:8080/5630 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/exec/hash-table-test.cc M be/src/exprs/expr-test.cc M be/src/runtime/buffered-block-mgr-test.cc M be/src/runtime/buffered-tuple-stream-test.cc M be/src/runtime/coordinator.cc M be/src/runtime/coordinator.h M be/src/runtime/data-stream-test.cc M be/src/runtime/exec-env.cc M be/src/runtime/exec-env.h M be/src/runtime/mem-tracker.cc M be/src/runtime/mem-tracker.h M be/src/runtime/plan-fragment-executor.cc M be/src/runtime/query-exec-mgr.cc M be/src/runtime/query-exec-mgr.h M be/src/runtime/query-state.cc M be/src/runtime/query-state.h M be/src/runtime/runtime-state.cc M be/src/runtime/runtime-state.h M be/src/runtime/test-env.cc M be/src/runtime/test-env.h M be/src/runtime/tmp-file-mgr-test.cc M be/src/scheduling/admission-controller.cc M be/src/service/fe-support.cc M be/src/service/impala-http-handler.cc M be/src/service/query-exec-state.cc 25 files changed, 372 insertions(+), 353 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6b46652932b5638993623e98d1f0d60d8380ba0 Gerrit-PatchSet: 12 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
