Tim Armstrong has posted comments on this change. Change subject: IMPALA-4678: move query MemTracker into QueryState ......................................................................
Patch Set 4: (1 comment) I didn't mean to push out PS8 - PS9 reverts the PS8 change. http://gerrit.cloudera.org:8080/#/c/5630/4/be/src/runtime/query-state.h File be/src/runtime/query-state.h: Line 135: std::unique_ptr<MemTracker> query_mem_tracker_; > MemTracker query_mem_tracker_ I did it this way to let us forward declare MemTracker and avoid pulling the MemTracker header in everywhere (since query-state.h will be included a lot of places). Also we need to pass arguments into the MemTracker constructor, which would force a fair bit of restructuring (could no longer use CreateQueryMemTracker(), etc). -- To view, visit http://gerrit.cloudera.org:8080/5630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6b46652932b5638993623e98d1f0d60d8380ba0 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
