Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4678: move query MemTracker into QueryState ......................................................................
Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/5630/7/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 1909: ExecEnv::GetInstance()->query_exec_mgr()->ReleaseQueryState(query_state_); feel free to add a QS::Release() convenience function if you think it's worth it. http://gerrit.cloudera.org:8080/#/c/5630/7/be/src/runtime/mem-tracker.h File be/src/runtime/mem-tracker.h: Line 100: static std::unique_ptr<MemTracker> CreateQueryMemTracker(const TUniqueId& id, instead of returning a unique_ptr, wouldn't it make more sense to create this in the querystate's objectpool? it needs to live as long as the qs. http://gerrit.cloudera.org:8080/#/c/5630/7/be/src/runtime/query-exec-mgr.cc File be/src/runtime/query-exec-mgr.cc: Line 59: bool created; since you don't use it, best to call it dummy or something like that. http://gerrit.cloudera.org:8080/#/c/5630/4/be/src/runtime/query-state.h File be/src/runtime/query-state.h: Line 120: > Done. yeah, we should really standardize across the entire codebase. not sure what the goog style guide prescribes. http://gerrit.cloudera.org:8080/#/c/5630/7/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: Line 388: /// Memory usage of this fragment instance, the child of 'query_mem_tracker_'. "a child of" -- To view, visit http://gerrit.cloudera.org:8080/5630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6b46652932b5638993623e98d1f0d60d8380ba0 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
