Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/5483/4/be/src/exec/hash-table-test.cc File be/src/exec/hash-table-test.cc: Line 74: ASSERT_OK(ExprContext::Prepare(build_expr_ctxs_, NULL, desc, &tracker_)) Missing semi-colon. Should have compiled the tests too. http://gerrit.cloudera.org:8080/#/c/5483/4/be/src/exprs/expr.cc File be/src/exprs/expr.cc: Line 376: Status Expr::Prepare(RuntimeState* state, const RowDescriptor& row_desc) { > It's kind of weird that the scope of what is initialised is different for E Good point. I like OpenContext() and CloseContext(). -- To view, visit http://gerrit.cloudera.org:8080/5483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefdc9aeeba033355cb9497e3a5d2363627dcf2f3 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
