Tim Armstrong has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext ......................................................................
Patch Set 6: (1 comment) One final issue. I'm assuming that we're going to rename OpenContext()/CloseContext() as part of the larger rename of ExprContext http://gerrit.cloudera.org:8080/#/c/5483/6/be/src/exprs/expr.cc File be/src/exprs/expr.cc: Line 112: Expr::~Expr() { I think we've been trying to move away from destructors releasing resources. Do you think it's reasonable to add an Expr::Close() function for this logic? -- To view, visit http://gerrit.cloudera.org:8080/5483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefdc9aeeba033355cb9497e3a5d2363627dcf2f3 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
