Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5483/6/be/src/exprs/expr.h File be/src/exprs/expr.h: Line 159: virtual BooleanVal GetBooleanVal(ExprContext* context, const TupleRow*); > these don't make sense here anymore, execution-related functions should be Not sure I understand this comment. These need to be overridden by subclasses of Exprs, no ? Not sure if it makes sense to put both ScalarFnCall::GetBooleanVal() or Literal::GetBooleanVal() in ExprCtx. Can you please elaborate ? -- To view, visit http://gerrit.cloudera.org:8080/5483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefdc9aeeba033355cb9497e3a5d2363627dcf2f3 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
