Tim Armstrong has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen ......................................................................
Patch Set 2: (4 comments) Looking better, just some minor things http://gerrit.cloudera.org:8080/#/c/5732/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 194: if (IsDefinedInImpalad(fn_name)) continue; I still don't entirely understand this. I understand why we don't want to materialize if it's defined in the Impala daemon, but I don't understand why we include gv -> fn mappings if the function isn't defined in the impala daemon, but not if the function is defined in the impala daemon. I don't see anything in the comment for 'callee_map_' that explains this either. http://gerrit.cloudera.org:8080/#/c/5732/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 63: DECLARE_bool(fe_support_disable_codegen); I don't think we want to expose this as a command-line option, do we? http://gerrit.cloudera.org:8080/#/c/5732/1/be/src/exprs/timestamp-functions-ir.cc File be/src/exprs/timestamp-functions-ir.cc: Line 57 > Without defining MIN_YEAR as a compilation constant, there isn't much to be I agree it probably doesn't matter too much, but we should generally just put the constants in header files so that we're consistent with the pattern. http://gerrit.cloudera.org:8080/#/c/5732/2/be/src/exprs/timestamp-functions.h File be/src/exprs/timestamp-functions.h: Line 42: static const int64_t MAX_YEAR_INTERVAL; I think we should define the constant values here, so that they can be inlined in any source files -- To view, visit http://gerrit.cloudera.org:8080/5732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40fdb035a565ae2f9c9fbf4db48a548653ef7608 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
