Tim Armstrong has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5732/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 194: if (IsDefinedInImpalad(fn_name)) continue; > And to elaborate a bit more, we choose to materialize a callee function ref Sounds reasonable - I think we just need some comments explaining it -- To view, visit http://gerrit.cloudera.org:8080/5732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40fdb035a565ae2f9c9fbf4db48a548653ef7608 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
