Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() ......................................................................
Patch Set 14: (4 comments) http://gerrit.cloudera.org:8080/#/c/5776/14/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: PS14, Line 238: (context->GetFunctionState(FunctionContext::FRAGMENT_LOCAL)); > nit: indent 4. Done PS14, Line 289: == > Should this be <= ? <= is nicer. This actually depends on operator precedence to not overflow itself o.O PS14, Line 352: UNLIKELY(resized == false) > nit: !resized. Done http://gerrit.cloudera.org:8080/#/c/5776/14/testdata/workloads/functional-query/queries/QueryTest/exprs.test File testdata/workloads/functional-query/queries/QueryTest/exprs.test: PS14, Line 1942: select sum(length(replace(y, x, 'bbbbbbbbbb'))) from (select cast(round( : float_col) AS STRING) as x, string_col as y from functional.alltypes) v; > This seems rather similar to the previous query ? How about we test the cas will try that -- To view, visit http://gerrit.cloudera.org:8080/5776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1780a7d8fee6d0db9dad148217fb6eb10f773329 Gerrit-PatchSet: 14 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
