Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() ......................................................................
Patch Set 16: (5 comments) http://gerrit.cloudera.org:8080/#/c/5776/16/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: PS16, Line 215: _ > for structs we don't usually use the underscore (but we do for classes), so Done http://gerrit.cloudera.org:8080/#/c/5776/16/be/src/udf/udf.cc File be/src/udf/udf.cc: PS16, Line 453: std::find(std::begin(local_allocations_), std::end(local_allocations_), ptr); > is this going to become a perf issue? let's just fix it Line 520: std::cout << "MAX_LENGTH, Trying to allocate " << len << std::endl; > delete kill the one above too? http://gerrit.cloudera.org:8080/#/c/5776/16/be/src/udf/udf.h File be/src/udf/udf.h: Line 583: /// buffers, and so don't need to be explicitly freed. > this isn't true in general, but it is true for StringVal's created via this will fix PS16, Line 586: StringVal > ... StringVal that is backed by a local allocation... will fix -- To view, visit http://gerrit.cloudera.org:8080/5776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1780a7d8fee6d0db9dad148217fb6eb10f773329 Gerrit-PatchSet: 16 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
