Dan Hecht has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() ......................................................................
Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/16/be/src/udf/udf.cc File be/src/udf/udf.cc: Line 520: std::cout << "MAX_LENGTH, Trying to allocate " << len << std::endl; > kill the one above too? hmm, didn't notice we already did that. yeah, I think we should get rid of it. looking at git history, it looks like it snuck in by mistake. -- To view, visit http://gerrit.cloudera.org:8080/5776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1780a7d8fee6d0db9dad148217fb6eb10f773329 Gerrit-PatchSet: 16 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
