Jim Apple has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/5969/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 3685: #define UTC_TO_MSC(X) ("cast(from_utc_timestamp('" X "', 'Europe/Moscow') as string)") Can you use https://gcc.gnu.org/onlinedocs/gcc/Push_002fPop-Macro-Pragmas.html for extra safety? PS2, Line 3693: 3 2:59:59.999... PS2, Line 3700: 59 Either use 59 seconds wherever possible or never. Line 3720: TestStringValue(UTC_TO_MSC("2014-10-25 22:00:00"), "2014-10-26 01:00:00"); Can you test the reverse direction for ambiguity? MSC 2014-10-26 01:30:00 should have two UTCs that correspond to it: UTC 2014-10-25 21:30:00 and UTC 2014-10-25 22:30:00 PS2, Line 3726: No "Still no" http://gerrit.cloudera.org:8080/#/c/5969/1/be/src/exprs/timestamp-functions.cc File be/src/exprs/timestamp-functions.cc: PS1, Line 194: January 19, 1992 > Added comment. In general, Timestamp timezone conversions are broken. Can you be a little more specific than "we do not handle" -- is that http://catb.org/jargon/html/N/nasal-demons.html , a crash, invalid output that is still a valid time_zone_ptr, etc. -- To view, visit http://gerrit.cloudera.org:8080/5969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e3f2c9f6ba29749a26bc1087e664637bc02528 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
