Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/5969/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 3685: #define UTC_TO_MSC(X) ("cast(from_utc_timestamp('" X "', 'Europe/Moscow') as string)") > Can you use https://gcc.gnu.org/onlinedocs/gcc/Push_002fPop-Macro-Pragmas.h Done PS2, Line 3693: 3 > 2:59:59.999... Done PS2, Line 3700: 59 > Either use 59 seconds wherever possible or never. Done Line 3720: TestStringValue(UTC_TO_MSC("2014-10-25 22:00:00"), "2014-10-26 01:00:00"); > Can you test the reverse direction for ambiguity? MSC 2014-10-26 01:30:00 s It actually is being tested on line 3723 (except it's 1am instead of 1:30am, but it's testing the same thing). This is the same behavior as timeanddate: https://www.timeanddate.com/worldclock/converter.html?iso=20141025T205900&p1=166&p2=1440 https://www.timeanddate.com/worldclock/converter.html?iso=20141025T220000&p1=166&p2=1440 (In this case we don't resolve the ambiguity by returning null) PS2, Line 3726: No > "Still no" Done -- To view, visit http://gerrit.cloudera.org:8080/5969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e3f2c9f6ba29749a26bc1087e664637bc02528 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
