Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/5969/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 3720: TestStringValue(UTC_TO_MSC("2014-10-25 21:59:59"), "2014-10-26 01:59:59"); > Why the different behavior? Is there a more canonical source for this? I think different behavior is OK because this is a completely different situation (timezone rules change vs a routine DST transition). I'm not sure what the canonical source for this is. I don't think we ever used one when working on timestamp. http://gerrit.cloudera.org:8080/#/c/5969/3/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: PS3, Line 3694: 3 > Make parallel with 2:59:59.999 below by using 3 both times or neither time Done http://gerrit.cloudera.org:8080/#/c/5969/1/be/src/exprs/timestamp-functions.cc File be/src/exprs/timestamp-functions.cc: PS1, Line 194: January 19, 1992 > Still open Cleared it up a bit. Let me know if you think the comment is clear now. -- To view, visit http://gerrit.cloudera.org:8080/5969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e3f2c9f6ba29749a26bc1087e664637bc02528 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
