Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/5969/5/be/src/exprs/timestamp-functions.cc File be/src/exprs/timestamp-functions.cc: Line 215: int msk_transition_day = 2456956; > AND_CAPS Done Line 215: int msk_transition_day = 2456956; > const for these three vars Done Line 226: tv.time().hours() < (msk_transition_hour_utc + msk_utc_offset) % 24)) { > Is this correct? Before, we had tv.time().hours() < 1. Now we have 22 + 4 % Yes, this is correct. The old (pre 2014) timezone is returned also for times between 1 and 2 now (before it was returned only for times before 1. We handle this case property by returning null on line 129. -- To view, visit http://gerrit.cloudera.org:8080/5969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e3f2c9f6ba29749a26bc1087e664637bc02528 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
