Alex Behm has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5969/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 3720: TestStringValue(UTC_TO_MSC("2014-10-25 22:00:00"), "2014-10-26 01:00:00"); > After speaking to Greg, we decided that we should return NULL for that 1 ho Just to clarify. We want to be consistent with the existing rule of "in case of ambiguity return NULL". The reason for the ambiguity is special for Moscow (permanent timezone change vs. DST change), but its still an ambiguity. -- To view, visit http://gerrit.cloudera.org:8080/5969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e3f2c9f6ba29749a26bc1087e664637bc02528 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
