Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5969/2/be/src/exprs/timestamp-functions.cc File be/src/exprs/timestamp-functions.cc: Line 195: // March 27, 2011 Moscow time transitioned to UTC+4 with no DST. NOTE: We currently > we do not handle them (error/NULL?), or do we not handle them correctly? We do not handle correctly (see patch 4) Line 199: return TIMEZONE_MSK_PRE_2011_DST; > mention the time also 22:00:000 UTC because we check for that below Done Line 209: } > might be clearer to have const variable here int transition_hour_utc = 22 a Done -- To view, visit http://gerrit.cloudera.org:8080/5969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e3f2c9f6ba29749a26bc1087e664637bc02528 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
