Hello Marcel Kornacker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6169
to look at the new patch set (#4).
Change subject: IMPALA-4997: Fix overflows in Sorter::TupleIterator
......................................................................
IMPALA-4997: Fix overflows in Sorter::TupleIterator
Various places in Sorter::TupleIterator multiplied two int values
(Sorter::Run::block_capacity_ and Sorter::TupleIterator::block_index_)
and assigned the result to an int64_t value
(Sorter::TupleIterator::buffer_start_index_). One such occurrence is in
be/src/runtime/sorter.cc#L1080. This multiplication could overflow for
runs with a large number of rows. Changing one of the operands to
int64_t fixes this.
Change-Id: Iea22aa96e0cc86102b60c6e551e9e607cef485c8
---
M be/src/runtime/sorter.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/6169/4
--
To view, visit http://gerrit.cloudera.org:8080/6169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea22aa96e0cc86102b60c6e551e9e607cef485c8
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
