Lars Volker has posted comments on this change. Change subject: IMPALA-4997: Fix overflows in Sorter::TupleIterator ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6169/1/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 1080: block_offset = (index % run->block_capacity_) * tuple_size; > Now I don't think I understand. The static_cast should have made this a 64- Yes. After chatting with Tim it seemed more thorough to change the "block_capacity_" to int64_t, since it refers to a number of tuples. This would also catch the other occurrences of this multiplication below. I'm now sure I'm communicating this clear enough, let's have a quick chat if you think this needs more clarification. -- To view, visit http://gerrit.cloudera.org:8080/6169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea22aa96e0cc86102b60c6e551e9e607cef485c8 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
