Lars Volker has posted comments on this change. Change subject: IMPALA-4997: Fix overflows in Sorter::TupleIterator ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6169/1/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 1080: buffer_start_index_ = static_cast<int64_t>(block_index_) * run->block_capacity_; > I think I understand now. You're saying this was correct before your patch, This (and other places) were broken before my patch. One option would be to add a cast to each one of them, but changing the type of block_capacity_ has the same effect and also should be more future-proof. -- To view, visit http://gerrit.cloudera.org:8080/6169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea22aa96e0cc86102b60c6e551e9e607cef485c8 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
