Alex Behm has posted comments on this change. Change subject: IMPALA-4998: Fix missing table lock acquisition. ......................................................................
Patch Set 1: (2 comments) I'll run exhaustive on this. http://gerrit.cloudera.org:8080/#/c/6177/1//COMMIT_MSG Commit Message: Line 11: passes locally. > Curious how GVO didn't catch this. Is the failure intermittent or something Now explained in commit msg. http://gerrit.cloudera.org:8080/#/c/6177/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: Line 957: return result.toTCatalogObject(); > Update this? Good catch. The code here doesn't seem very useful. I modified it to make more sense, and then the locking issue goes away naturally. -- To view, visit http://gerrit.cloudera.org:8080/6177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e0270daf59fce95f1a1520fc5aaf91d3a7b99fe Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-HasComments: Yes
