Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4998: Fix missing table lock acquisition. ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6177/5/fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java File fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java: Line 318: if (tbl == null || tbl instanceof IncompleteTable || !tbl.isLoaded()) return; Doesn't this mean that we can never "refresh" an IncompleteTable? Without this patch, we'd submit a loadAsync() request if we encounter an IncompleteTable and with this patch we just return. Isn't it a behavioral regression? -- To view, visit http://gerrit.cloudera.org:8080/6177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e0270daf59fce95f1a1520fc5aaf91d3a7b99fe Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-HasComments: Yes
