Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4998: Fix missing table lock acquisition. ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6177/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: Line 768: if (tbl == null || tbl.isLoaded()) return tbl; I'm wondering if this can potentially return an IncompleteTable and that eventually hits the preconditions check in reloadTable(). Reason being, IncompleteTable.isLoaded() needn't always return false. > public boolean isLoaded() { return cause_ != null; } Especially the static method that we use to create IncompleteTables sets the cause_ as null. public static IncompleteTable createUninitializedTable(Db db, String name) { return new IncompleteTable(db, name, null); } Please correct me if I'm wrong. PS3, Line 926: which not be rephrase? -- To view, visit http://gerrit.cloudera.org:8080/6177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e0270daf59fce95f1a1520fc5aaf91d3a7b99fe Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-HasComments: Yes
