Joe McDonnell has posted comments on this change. Change subject: IMPALA-4899: Fix parquet table writer dictionary leak ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6181/3/be/src/exec/hdfs-table-sink.h File be/src/exec/hdfs-table-sink.h: Line 172: const std::unique_ptr<OutputPartition>& output_partition, > Just passing the raw pointer seems ok to me - I think you can do everything You're right. Now that I think about it, there isn't much reason to use a const unique_ptr reference. I've switched it back to a raw pointer. -- To view, visit http://gerrit.cloudera.org:8080/6181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e354086ad24071d4fbf823f25f5df23933688f Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
