Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4899: Fix parquet table writer dictionary leak ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6181/4/be/src/exec/hdfs-table-sink.h File be/src/exec/hdfs-table-sink.h: Line 184: typedef std::pair<std::unique_ptr<OutputPartition>, std::vector<int32_t>> PartitionPair; please include updates to the class comments (of the affected classes) that briefly describe the memory management intentions. since we got this wrong last time around it appears to be subtle/non-obvious enough to warrant a description. -- To view, visit http://gerrit.cloudera.org:8080/6181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e354086ad24071d4fbf823f25f5df23933688f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
