Joe McDonnell has posted comments on this change. Change subject: IMPALA-4899: Fix parquet table writer dictionary leak ......................................................................
Patch Set 4: > is there a way to ascertain the leak-free behavior in a test? I don't see a difference in the runtime profile with this patch vs without. The way I have been testing is by hand. I do a clustered insert into a partitioned table and look at the memory usage in top. It is a very clear difference, but I'm not sure how to write a test around it. I tried setting a mem_limit and testing without my patch, but the mem_limit is not enforced. -- To view, visit http://gerrit.cloudera.org:8080/6181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e354086ad24071d4fbf823f25f5df23933688f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
