Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4997: Fix overflows in Sorter::TupleIterator ......................................................................
IMPALA-4997: Fix overflows in Sorter::TupleIterator Various places in Sorter::TupleIterator multiply two int values (Sorter::Run::block_capacity_ and Sorter::TupleIterator::block_index_) and assigned the result to an int64_t value (Sorter::TupleIterator::buffer_start_index_). One such occurrence is in be/src/runtime/sorter.cc#L1080. This multiplication could overflow for runs with a large number of rows. Changing one of the operands to int64_t fixes this. To test this Matt Mulder ran the failing query from IMPALA-4997 on a private cluster and it succeeded. Change-Id: Iea22aa96e0cc86102b60c6e551e9e607cef485c8 Reviewed-on: http://gerrit.cloudera.org:8080/6169 Reviewed-by: Lars Volker <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/runtime/sorter.cc 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Verified Lars Volker: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea22aa96e0cc86102b60c6e551e9e607cef485c8 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]>
