Matthew Jacobs has posted comments on this change.

Change subject: Fix setup / download order in build scripts
......................................................................


Patch Set 1:

(1 comment)

thanks for doing this - 1 question about 'footer' now

http://gerrit.cloudera.org:8080/#/c/6249/1/functions.sh
File functions.sh:

PS1, Line 238: # Usage: footer <package name> <package version>
             : function footer() {
just realized this now makes even less sense. maybe we should rename this like 
'finalize_package_build'?


-- 
To view, visit http://gerrit.cloudera.org:8080/6249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I287f091c8e772c08c8a61644d08117145b1ef16d
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to