Lars Volker has posted comments on this change.

Change subject: Fix setup / download order in build scripts
......................................................................


Patch Set 4: Code-Review+2 Verified+1

(2 comments)

Build succeeded locally. Carrying Tim's +2. I will submit this and start a 
publishing build next.

http://gerrit.cloudera.org:8080/#/c/6249/3/functions.sh
File functions.sh:

PS3, Line 104: prepare
> not for now or related to this change, but at some point we should come bac
I agree, it's pretty confusing.


http://gerrit.cloudera.org:8080/#/c/6249/3/source/avro/build.sh
File source/avro/build.sh:

Line 26:   # Download the dependency from S3
> Maybe move all of these download_dependency calls into if needs_build_packa
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I287f091c8e772c08c8a61644d08117145b1ef16d
Gerrit-PatchSet: 4
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to