Lars Volker has posted comments on this change. Change subject: Fix setup / download order in build scripts ......................................................................
Patch Set 1: (1 comment) Thanks for the review, please see PS3. http://gerrit.cloudera.org:8080/#/c/6249/1/functions.sh File functions.sh: PS1, Line 238: # Usage: footer <package name> <package version> : function footer() { > just realized this now makes even less sense. maybe we should rename this l Good point, I changed it. I added a comment to the function, too, but it wasn't entirely clear to me what it does. -- To view, visit http://gerrit.cloudera.org:8080/6249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I287f091c8e772c08c8a61644d08117145b1ef16d Gerrit-PatchSet: 1 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
