Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6261/1/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: PS1, Line 1033: CreateTableStmt.CreateTableAsSelectStmt maybe I'll see why this is necessary later, but this seems odd since it looks like it would create a CreateTableAsSelectStmt, only to be passed as an arg to CreateTableAsSelectStmt. http://gerrit.cloudera.org:8080/#/c/6261/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: PS1, Line 68: public static CreateTableStmt CreateTableAsSelectStmt(TableDef tableDef) { : CreateTableStmt stmt = new CreateTableStmt(tableDef); : stmt.createAsSelect_ = true; : return stmt; : } yeah, per my comment in sql-parser this seems odd to have this parameter on CreateTableStmt while the CreateTableAsSelectStmt consumes this. why can't you just set isExternal = true in the TableDef? Maybe I'm missing something? -- To view, visit http://gerrit.cloudera.org:8080/6261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9aa82809a6c0c5e6386827314b7e5b520c1a6633 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
