Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6261/4//COMMIT_MSG Commit Message: PS4, Line 9: No reason not to allow this. Not necessary. Also, I find this whole paragraph confusing - for example what thrift protocol? Why would it need to be changed? (not that I'm saying you should explain this, it may be an unnecessary detail). Obviously, you should assume that anyone reading this has no context for the work that you've been doing up to this point. http://gerrit.cloudera.org:8080/#/c/6261/4/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: Line 240: * Analyzes and checks parameters specified for ingested external Kudu tables. Since ingested isn't a term we use anywhere else (AFAIK), you should explain what you mean by it, something like: "Analyzes and checks parameters specified for external tables that already exist in Kudu." -- To view, visit http://gerrit.cloudera.org:8080/6261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9aa82809a6c0c5e6386827314b7e5b520c1a6633 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
