Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6261/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: PS1, Line 210: !createAsSelect how about instead of this, checking if there were columns specified or not? PS1, Line 211: analyzeExternalKuduTableParams(analyzer); : } else { : analyzeManagedKuduTableParams(analyzer); It might be easier to understand if we rebrand these functions now, e.g. analyzeExistingKuduTableParams and analyzeNewKuduTableParams. http://gerrit.cloudera.org:8080/#/c/6261/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: PS2, Line 57: // Is this a CREATE TABLE ... AS SELECT statment : private boolean createAsSelect_ = false; This just doesn't feel right to me, especially given that this is only used on the Kudu path. http://gerrit.cloudera.org:8080/#/c/6261/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: PS2, Line 1649: why remove this? -- To view, visit http://gerrit.cloudera.org:8080/6261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9aa82809a6c0c5e6386827314b7e5b520c1a6633 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
