Dan Hecht has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/5816/9/be/src/exec/union-node.cc File be/src/exec/union-node.cc: Line 148: row_batch->MarkNeedsDeepCopy(); > The problematic memory is memory that is never attached to any batch and is Which memory is this? buffered-tuple-stream buffer? anything else? Will this be addressed by IMPALA-4179, or is it different? This is probably an argument for needing ref counting on buffers so a reference can be held both by the row batch and a child node, so that Close() can happen "early" without freeing the buffer. We need to revisit this and clean up how the child closing happens here. Let's leave a todo for that referencing the appropriate jira. -- To view, visit http://gerrit.cloudera.org:8080/5816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
