Tim Armstrong has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/5816/9/be/src/exec/union-node.cc File be/src/exec/union-node.cc: Line 148: row_batch->MarkNeedsDeepCopy(); > Which memory is this? buffered-tuple-stream buffer? anything else? Will t Yeah IMPALA-4179 covers that. IMPALA-4179 lists a few examples. One of the trickier cases right now is "Local" allocations in FunctionContexts - batches can reference that memory but there's no way to transfer it out of the FunctionContext. I think the path of least resistance is to add a RowBatch parameter to Close() and attach such resources to the RowBatch. Ref-counting may give more flexibility but probably would require rewriting many things. -- To view, visit http://gerrit.cloudera.org:8080/5816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
