Tim Armstrong has posted comments on this change. Change subject: IMPALA-4008: Don't bake fields into generated IR functions of OldHashTable ......................................................................
Patch Set 1: (1 comment) Forgot to mention - the patch looks good aside from the minor things. If we were planning to support OldHashTable longer-term we could clear up that code a bit but this looks fine as a fix for code we're working on deprecating. http://gerrit.cloudera.org:8080/#/c/6263/1/be/src/exec/old-hash-table.cc File be/src/exec/old-hash-table.cc: Line 325: // TODO: refactor this to somewhere else? This is not hash table specific Remove TODO if you're not going to do this in this patch? -- To view, visit http://gerrit.cloudera.org:8080/6263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75500827dff56b1fa9e5296e8e8d8667ab54aef8 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
