Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4008: Don't bake fields into generated IR functions of OldHashTable ......................................................................
IMPALA-4008: Don't bake fields into generated IR functions of OldHashTable To support sharing generated code across fragment instances, no fragment instance specific states should be baked into the IR. All cases were addressed previously except for the old hash tables used for legacy agg/join. This change fixes the old hash tables to not bake its fields in the generated IR functions. Similar to previous patches, some cross-compiled thin wrappers are introduced to access the fields of interest from an OldHashTable object. Change-Id: I75500827dff56b1fa9e5296e8e8d8667ab54aef8 Reviewed-on: http://gerrit.cloudera.org:8080/6263 Reviewed-by: Michael Ho <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/codegen/gen_ir_descriptions.py M be/src/codegen/impala-ir.cc M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h M be/src/exec/CMakeLists.txt M be/src/exec/hash-table-ir.cc M be/src/exec/hash-table.cc M be/src/exec/hash-table.h A be/src/exec/old-hash-table-ir.cc M be/src/exec/old-hash-table.cc M be/src/exec/old-hash-table.h 11 files changed, 184 insertions(+), 80 deletions(-) Approvals: Impala Public Jenkins: Verified Michael Ho: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75500827dff56b1fa9e5296e8e8d8667ab54aef8 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
