Tim Armstrong has posted comments on this change. Change subject: IMPALA-4008: Don't bake fields into generated IR functions of OldHashTable ......................................................................
Patch Set 2: Code-Review+2 (1 comment) I feel pretty confident +2ing - we have good test coverage of the in-memory joins and this patch is only changing the internal implementation of deprecated code. I assume you did a test run using this code path but if not it would be good to do before merging. http://gerrit.cloudera.org:8080/#/c/6263/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 1458: // Load &build_expr_ctxs_[0] Stray comment. -- To view, visit http://gerrit.cloudera.org:8080/6263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75500827dff56b1fa9e5296e8e8d8667ab54aef8 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
