Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() ......................................................................
IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() GetBytes only sets status in the case of an error. This means that ReadPageHeader needs to initialize the status variable so that the status.ok() check is accurate after the GetBytes call. I verified that the other uses of status are ok. Most do not check status.ok() directly, but rely on the return value of the function setting status. Change-Id: Ie22a8cf6b53f507c378c2efe302482409935184e Reviewed-on: http://gerrit.cloudera.org:8080/6328 Reviewed-by: Marcel Kornacker <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/exec/parquet-column-readers.cc 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Marcel Kornacker: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie22a8cf6b53f507c378c2efe302482409935184e Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
