Joe McDonnell has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6328/1//COMMIT_MSG Commit Message: Line 9: GetBytes only sets status in the case of an error. This means that > long lines Done Line 13: I verified that the other uses of status are ok. Most do not check > I think we should change GetBytes() to always initialize status. The functi Since this JIRA is a build blocker, I am reluctant to delay it to do performance tests. I filed IMPALA-5060 to track that change. -- To view, visit http://gerrit.cloudera.org:8080/6328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie22a8cf6b53f507c378c2efe302482409935184e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
