Joe McDonnell has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() ......................................................................
Patch Set 1: Just to make it a matter of record: GetBytes's call signature is mirrored by several other functions: ReadBytes, SkipBytes, ReadBoolean, ReadInt, ReadVLong, etc. See scanner-context.h for the full list. A change to the signatures would impact several files and a hundred or so calls. It might still be worth doing, but it is something that should be done in a separate JIRA. -- To view, visit http://gerrit.cloudera.org:8080/6328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie22a8cf6b53f507c378c2efe302482409935184e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
