Tim Armstrong has posted comments on this change. Change subject: IMPALA-5077: add NUMA and current cpu to CpuInfo ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/6402/2/be/src/util/cpu-info.cc File be/src/util/cpu-info.cc: PS2, Line 161: result > Just inline sched_getcpu() if you aren't going to use result. Done PS2, Line 165: Running > "Built"? Good point - done. Line 183: string filename = dir_it->path().filename().string(); > const Done Line 192: core_to_numa_node_ = new int[max_num_cores_]; > Will ASAN complain about this memory leak? LeakSanitiser would report it as "reachable" but it's easy enough to switch to unique_ptr. -- To view, visit http://gerrit.cloudera.org:8080/6402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0525228a56bcf20c45f78ee1ba1d300c74cf4d05 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
