Henry Robinson has posted comments on this change. Change subject: IMPALA-5077: add NUMA and current cpu to CpuInfo ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/6402/3/be/CMakeLists.txt File be/CMakeLists.txt: PS3, Line 282: nit: remove space? http://gerrit.cloudera.org:8080/#/c/6402/3/be/src/common/CMakeLists.txt File be/src/common/CMakeLists.txt: PS3, Line 53: CONFIGURE_FILE Does cmake automatically understand that compilation depends on this step? http://gerrit.cloudera.org:8080/#/c/6402/3/be/src/util/cpu-info.cc File be/src/util/cpu-info.cc: PS3, Line 181: for (; dir_it != fs::directory_iterator(); ++dir_it) { directory_iterator doesn't work with ranged for syntax? http://gerrit.cloudera.org:8080/#/c/6402/3/be/src/util/cpu-info.h File be/src/util/cpu-info.h: PS3, Line 87: hould : /// be used by Impala. what does 'should be used' mean? Available for use? -- To view, visit http://gerrit.cloudera.org:8080/6402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0525228a56bcf20c45f78ee1ba1d300c74cf4d05 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
