Tim Armstrong has posted comments on this change. Change subject: IMPALA-5077: add NUMA and current cpu to CpuInfo ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/6402/5/be/src/util/cpu-info.cc File be/src/util/cpu-info.cc: PS5, Line 161: getcpu > should that say sched_getcpu()? Yes - sched_getcpu() is a glibc wrapper around the getcpu() syscall. Line 186: LOG(FATAL) << "Could not find nodes in /sys/devices/system/node"; > are we confident that all distros impala runs on will have this? Oops, I intended to check for the existence of the directory (it's not present if the kernel has NUMA support disabled). Now all errors should be non-fatal and just fall back to assuming one node. -- To view, visit http://gerrit.cloudera.org:8080/6402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0525228a56bcf20c45f78ee1ba1d300c74cf4d05 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
