Zach Amsden has posted comments on this change. Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6503/1/be/src/exprs/timezone_db.cc File be/src/exprs/timezone_db.cc: PS1, Line 676: char *filestr = strdup(path.string().c_str()); > I am not suggesting that in this case, though. vector<char> seems like the Did not see all this discussion. I think I'll just wrap in a unique_ptr. PS1, Line 687: return > this would leak filestr. My original version omitted the free entirely and just leaked filestr(), which seems lazy but okay for a one time initialization. -- To view, visit http://gerrit.cloudera.org:8080/6503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I490f741403ea2004bc51394aa1251577337b1e1d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
