Henry Robinson has posted comments on this change. Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db ......................................................................
Patch Set 4: Code-Review+2 (2 comments) lgtm, thanks for working through the alternatives. http://gerrit.cloudera.org:8080/#/c/6503/4/be/src/exprs/timezone_db.cc File be/src/exprs/timezone_db.cc: PS4, Line 674: remove one space PS4, Line 676: std remove std:: Also can't hurt to have a one-line comment explaining that we need a mutable char array for mkstemp. -- To view, visit http://gerrit.cloudera.org:8080/6503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I490f741403ea2004bc51394aa1251577337b1e1d Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
