Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4883: Union Codegen ......................................................................
Patch Set 6: (9 comments) http://gerrit.cloudera.org:8080/#/c/6459/6/be/src/exec/union-node-ir.cc File be/src/exec/union-node-ir.cc: PS6, Line 29: dst_batch->tuple_data_pool() > is this where that mem-pool in the class is used when codegening? Why not Done. http://gerrit.cloudera.org:8080/#/c/6459/6/be/src/exec/union-node.cc File be/src/exec/union-node.cc: Line 98: > Extra blank lines. Done PS6, Line 113: abort codegen entirely. > this doesn't seem to match the code. wouldn't we have already filled in cod Reprased. Added a test case. Line 235: if (ReachedLimit()) { > I don't think this can be taken now, right? Since we don't increment num_ro Removed completely. I considered adding some extra logic to calculate if we reached the limit and the child can be closed, but I decided not to (to reduce complexity and it makes the code uglier for this special case). Let me know if you disagree with this decision. Basically as a result of this, if we hit the limit, the child will be closed in UnionNode.Close() instead of here. http://gerrit.cloudera.org:8080/#/c/6459/6/be/src/exec/union-node.h File be/src/exec/union-node.h: PS6, Line 68: Temporarily stores references to materialized tuples by a codegened function > i'm not sure what this means. MemPools don't store references, they contain Rewrote the comment. Also changed it so that mem-pool is used by the non-codegen version as well. PS6, Line 71: TODO: Remove this when no longer necessary in the future. > do we have a concrete jira for when this won't be necessary? I couldn't find one, but I think Michael knows more about this. PS6, Line 96: Jitted > usually we say "codegen'ed" Done. I wrote it like this because I saw it written like that in other files such as (partitioned-aggregation-node.h). Line 116: /// call on the child. > Maybe mention that these GetNext* functions don't apply the limit? Done. I wasn't really sure where to put the comment, so I put it at the top. PS6, Line 127: Increments 'num_rows_returned_' and : /// 'child_row_idx_' > I think this needs an update. Done -- To view, visit http://gerrit.cloudera.org:8080/6459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4107d27582ff5416172810364a6e76d3d93c439 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
