Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4883: Union Codegen ......................................................................
Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/6459/7/be/src/exec/union-node-ir.cc File be/src/exec/union-node-ir.cc: PS7, Line 34: RuntimeState* state > Is this not used at all ? Good catch, removed. PS7, Line 45: child_row_idx < num_child_batch_rows) { > There is a macro called FOREACH_ROW() which is useful for iterating through Done http://gerrit.cloudera.org:8080/#/c/6459/6/be/src/exec/union-node.h File be/src/exec/union-node.h: PS6, Line 71: the pointer to the mem pool is hard coded in the codegen' > I couldn't find one, but I think Michael knows more about this. Created IMPALA-5192 -- To view, visit http://gerrit.cloudera.org:8080/6459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4107d27582ff5416172810364a6e76d3d93c439 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
